[Feature] compare for 2 diff models by Manan17 · Pull Request #4356 · unslothai/unsloth

Manan17 · 2026-03-17T10:19:05Z

Added generalized model comparison that lets users compare any two models side-by-side, while preserving the existing fast LoRA compare (simultaneous, adapter toggle) as an auto-detected fast path. When a LoRA is loaded, compare works exactly as before; otherwise, a new general compare mode renders per-side model pickers and orchestrates sequential load → generate → load → generate with progress toasts, an "already loaded" backend optimization to skip redundant reloads, immediate user message display on both sides, and a locked send button until both sides complete. Supports GGUF, LoRA, and standard models.

chatgpt-codex-connector · 2026-03-17T10:19:09Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.

for more information, see https://pre-commit.ci

gemini-code-assist · 2026-03-17T10:19:33Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the model comparison capabilities by introducing a flexible, generalized system. Users can now select and compare any two models, including GGUF, LoRA, and standard models, side-by-side. The system intelligently detects if a LoRA is loaded, defaulting to the existing fast comparison method, while providing a new, robust sequential loading and generation process for general comparisons, complete with user feedback and optimizations. This broadens the utility of the comparison feature beyond just LoRA models, making it a more versatile tool for model evaluation.

Highlights

Generalized Model Comparison: Introduced a new feature allowing users to compare any two models side-by-side, expanding beyond the previous LoRA-only comparison.
Optimized Model Loading: Implemented an 'already loaded' check in the backend to prevent redundant model reloads during comparison, improving efficiency.
Enhanced User Experience: Added progress toasts and immediate user message display for the new general compare mode, providing clear feedback during sequential model loading and generation.
Flexible Model Support: The comparison now supports GGUF, LoRA, and standard models, with the existing fast LoRA compare path automatically detected and preserved.

Changelog

studio/backend/routes/inference.py
- Added an optimization to skip model reloading if the requested model (GGUF or Unsloth) is already active in the backend.
studio/frontend/src/features/chat/api/chat-adapter.ts
- Updated resolveUseAdapter to disable the adapter toggle for the new model1 and model2 comparison threads.
studio/frontend/src/features/chat/chat-page.tsx
- Defined a new CompareModelSelection type for model comparison.
- Implemented useIsLoraCompare to determine if the current comparison is a LoRA-specific one.
- Refactored the CompareContent component to dynamically render either LoraCompareContent (for LoRA comparisons) or GeneralCompareContent (for generalized comparisons).
- Introduced GeneralCompareContent to manage the UI and logic for comparing any two models, including model selectors and state management for two distinct models.
- Modified the canCompare logic to enable comparison for any loaded checkpoint, not just LoRAs.
- Passed model lists (models, loraModels) to the CompareContent component.
studio/frontend/src/features/chat/shared-composer.tsx
- Imported toast for user notifications and loadModel for dynamic model loading.
- Extended the CompareHandle interface with new methods (appendMessage, startRun, waitForRunEnd) to support sequential generation.
- Implemented these new CompareHandle methods in RegisterCompareHandle.
- Updated SharedComposer to accept model1 and model2 props for generalized comparison.
- Implemented the core logic for generalized comparison within the send function, orchestrating sequential model loading, message display, generation, and progress toasts.
- Adjusted the canSend and stop button logic to reflect the new comparing state.
studio/frontend/src/features/chat/thread-sidebar.tsx
- Adjusted the thread grouping logic to correctly categorize single threads that are not part of a comparison pair.
studio/frontend/src/features/chat/tour/steps.tsx
- Updated the description for the "Compare mode" tour step to reflect the new generalized comparison capabilities.
studio/frontend/src/features/chat/types.ts
- Expanded the ModelType enum to include model1 and model2 for generalized comparison threads.

Activity

No specific activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a generalized model comparison feature, allowing side-by-side comparison of any two models, which is a significant enhancement. The implementation correctly preserves the existing LoRA fast-path compare and adds a new sequential load-and-generate flow for the general case. The backend is optimized to avoid redundant model reloads, and the frontend provides good user feedback with progress toasts. My review includes a few suggestions for improving code clarity and robustness, such as removing an unused variable, refining exception handling, and simplifying a redundant expression.

for more information, see https://pre-commit.ci

… sizing (#4369) Co-authored-by: imagineer99 <samleejackson0@gmail.com>

rolandtannous · 2026-03-17T18:57:14Z

great work!

* compare for 2 diff models * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * resolving gemini comments * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix(studio): refine model-load toast stop action and compare selector sizing (unslothai#4369) Co-authored-by: imagineer99 <samleejackson0@gmail.com> --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Daniel Han <danielhanchen@gmail.com> Co-authored-by: imagineer99 <samleejackson0@gmail.com>

compare for 2 diff models

23c08f3

Manan17 requested review from rolandtannous and wasimysaid as code owners March 17, 2026 10:19

[pre-commit.ci] auto fixes from pre-commit.com hooks

ad3deda

for more information, see https://pre-commit.ci

Manan17 changed the title ~~compare for 2 diff models~~ [Feature] compare for 2 diff models Mar 17, 2026

gemini-code-assist Bot reviewed Mar 17, 2026

View reviewed changes

Comment thread studio/backend/routes/inference.py

Comment thread studio/backend/routes/inference.py

Comment thread studio/frontend/src/features/chat/shared-composer.tsx Outdated

Manan17 and others added 4 commits March 17, 2026 10:28

resolving gemini comments

c0398ed

[pre-commit.ci] auto fixes from pre-commit.com hooks

fd03415

for more information, see https://pre-commit.ci

fix(studio): refine model-load toast stop action and compare selector…

6a93f74

… sizing (#4369) Co-authored-by: imagineer99 <samleejackson0@gmail.com>

Merge branch 'main' into feature/compare-two-diff-models

0b9f6b8

rolandtannous approved these changes Mar 17, 2026

View reviewed changes

rolandtannous merged commit 93ab09d into main Mar 17, 2026
5 checks passed

rolandtannous deleted the feature/compare-two-diff-models branch March 17, 2026 18:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Feature] compare for 2 diff models#4356

[Feature] compare for 2 diff models#4356
rolandtannous merged 6 commits into
mainfrom
feature/compare-two-diff-models

Manan17 commented Mar 17, 2026

Uh oh!

chatgpt-codex-connector Bot commented Mar 17, 2026

Uh oh!

gemini-code-assist Bot commented Mar 17, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rolandtannous commented Mar 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Manan17 commented Mar 17, 2026

Uh oh!

chatgpt-codex-connector Bot commented Mar 17, 2026

Uh oh!

gemini-code-assist Bot commented Mar 17, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rolandtannous commented Mar 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants